add image support in file upload #2007
Open
+200
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata into image-support-file-upload
dirkbrnd
reviewed
Feb 5, 2025
Comment on lines
155
to
161
| if image: | ||
| base64_image = await process_image(image) | ||
| try: | ||
| base64_image = await process_image(image) | ||
| base64_images.append(base64_image) | ||
| except Exception as e: | ||
| logger.error(f"Error processing image: {e}") | ||
| raise HTTPException(status_code=400, detail="Error processing image") |
There was a problem hiding this comment.
I think we can remove this?
dirkbrnd
reviewed
Feb 5, 2025
Comment on lines
139
to
145
| if image: | ||
| base64_image = process_image(image) | ||
| try: | ||
| base64_image = process_image(image) | ||
| base64_images.append(base64_image) | ||
| except Exception as e: | ||
| logger.error(f"Error processing image: {e}") | ||
| raise HTTPException(status_code=400, detail="Error processing image") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update.
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.shand./scripts/validate.shto ensure code is formatted and linted.Additional Notes
Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).